-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: Add update and render functions to Scene, SceneObject and Component classes #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9d8d705
refactor: update Component class
MichalSzandar 4c804c2
fix: format code
MichalSzandar 839f713
feat: add render and update functions to Scene, SceneObject and Compo…
MichalSzandar e53d1e2
fix: remove copy/move constructors from component
MichalSzandar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| Checks: 'bugprone-*,cppcoreguidelines-*,performance-*,readability-*,-cppcoreguidelines-avoid-magic-numbers,-cppcoreguidelines-pro-bounds-array-to-pointer-decay' | ||
| WarningsAsErrors: '' | ||
| HeaderFilterRegex: '.*' | ||
| ExcludeHeaderFilterRegex: '.*\.(pb\.h|pb\.cc)$' | ||
| HeaderFilterRegex: '^(?!.*\.(pb\.h|pb\.cc)$).*$' | ||
| FormatStyle: 'file' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,28 @@ | ||
| #ifndef COMPONENT_HPP | ||
| #define COMPONENT_HPP | ||
|
|
||
| #include <memory> | ||
|
|
||
| class SceneObject; | ||
| class SDL_Renderer; | ||
| struct Context; | ||
|
|
||
| class Component { | ||
| public: | ||
| Component() = default; | ||
| Component() = delete; | ||
| Component(std::shared_ptr<SceneObject> owner) : owner(owner) {} | ||
| virtual ~Component() = default; | ||
|
|
||
| Component(const Component&) = default; | ||
| Component(Component&&) = default; | ||
| Component& operator=(const Component&) = default; | ||
| Component& operator=(Component&&) = default; | ||
| Component(const Component&) = delete; | ||
| Component(Component&&) = delete; | ||
| Component& operator=(const Component&) = delete; | ||
| Component& operator=(Component&&) = delete; | ||
|
|
||
| virtual void update(const Context& context) = 0; | ||
| virtual void render(SDL_Renderer* renderer) = 0; | ||
|
|
||
| protected: | ||
| std::weak_ptr<SceneObject> owner; | ||
| }; | ||
|
|
||
| #endif // COMPONENT_HPP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| #include "scene/Scene.hpp" | ||
|
|
||
| #include "scene/SceneObject.hpp" | ||
|
|
||
| void Scene::update(const Context& ctx) { | ||
| for (const auto& obj : objects) { | ||
| obj->update(ctx); | ||
| } | ||
| } | ||
|
|
||
| void Scene::render(SDL_Renderer* renderer) { | ||
| for (const auto& obj : objects) { | ||
| if (obj->isVisible) { | ||
| obj->render(renderer); | ||
| } | ||
| } | ||
| } | ||
|
MichalSzandar marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.