-
Notifications
You must be signed in to change notification settings - Fork 42
Add Memgraph support #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ tsconfig.tsbuildinfo | |
| config.yaml | ||
| .env | ||
| docker/.neo4j/ | ||
| docker/.memgraph/ | ||
| yarn-error.log | ||
| dist/ | ||
| coverage/ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,14 @@ integrations: | |
| config: | ||
| AUTH_TOKEN: example-token | ||
| ORGANIZATION_SLUG: example-organization | ||
| storage: | ||
| - | ||
| engine: memgraph | ||
| config: | ||
| username: | ||
| password: | ||
| uri: bolt://localhost:3000 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is port 3000 listed here the default port for uploading data to Memgraph? I'm by no means an expert at Memgraph, but I was under the impression that like Neo4j it uses port 7687 for the bolt connection to upload data.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You are completely right, Memgraph uses the same port. Memgraph Lab has 3000 for the visualization part so this was a bit of a "tip-feller" from my side |
||
| database: memgraph | ||
| storage: | ||
| - | ||
| engine: neo4j | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| version: '3.8' | ||
| services: | ||
| memgraph: | ||
| image: 'memgraph/memgraph-platform' | ||
| hostname: memgraph | ||
| ports: | ||
| - '3000:3000' | ||
| - '7444:7444' | ||
| - '7687:7687' | ||
| volumes: | ||
| - mg_lib:/var/lib/memgraph | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are these the correct volume paths? It looks like you added |
||
| - mg_log:/var/log/memgraph | ||
| - mg_etc:/etc/memgraph | ||
| entrypoint: ["/usr/bin/supervisord"] | ||
| volumes: | ||
| mg_lib: | ||
| mg_log: | ||
| mg_etc: | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is just an example file, but we technically can't have two
storageentries in a valid config file. I'd recommend creating a separate example file for showing a Memgraph configuration.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created another
config.yaml.memgraph.example, the name might be too long and I can change it if necessary