Skip to content

Throw appropriate error for pad_sequence input of length > maxlen #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sean-gauss wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Throw appropriate error for pad_sequence input of length > maxlen #186

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0b1a3e
Update sentiment.jl
sean-gauss Jan 15, 2020
a190c9c
Update sentiment.jl
sean-gauss Jan 18, 2020
63ddb7c
Update sentiment.jl
sean-gauss Feb 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/sentiment.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@ function pad_sequences(l, maxlen=500)
push!(res, ele)
end
return res
end

else
print("Not Possible to have string length greater than maximum length")
Comment thread
Ayushk4 marked this conversation as resolved.
Outdated
end
Comment thread
Ayushk4 marked this conversation as resolved.
Outdated
end

function read_weights(filename=sentiment_weights)
Expand Down