Relax Fill return type in mvlognormal tests#1890
Merged
devmotion merged 2 commits intoJuliaStats:masterfrom Aug 26, 2024
Merged
Relax Fill return type in mvlognormal tests#1890devmotion merged 2 commits intoJuliaStats:masterfrom
devmotion merged 2 commits intoJuliaStats:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1890 +/- ##
=======================================
Coverage 85.99% 85.99%
=======================================
Files 144 144
Lines 8666 8666
=======================================
Hits 7452 7452
Misses 1214 1214 ☔ View full report in Codecov by Sentry. |
devmotion
reviewed
Aug 26, 2024
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
devmotion
approved these changes
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In JuliaArrays/FillArrays.jl#385 I'm working on improving how broadcasting works for FillArrays. One of the changes is that some types may be inferred differently, so e.g.
Currently
Proposed:
Currently, in one of the
mvlognormaltests, this package is explicitly checking for aFill. This PR relaxes this to aUnion{Fill, Ones}so that the tests pass either way.