Update TableTraits.jl integration#33
Merged
malmaud merged 2 commits intoJuliaPy:masterfrom Sep 5, 2018
Merged
Conversation
davidanthoff
changed the title
Contributor
Author
|
I thought this should work now, but there seems to be some generic testing error related to numpy or something? Any idea what is going on there? |
Member
|
I think the CI error was fixed by #32. |
davidanthoff
force-pushed
the
tabletraits
branch
from
7892d3e to
552cfb5
Compare
Contributor
Author
|
Alright, trying with a rebased version. |
Contributor
Author
|
Ok, I think this is ready to be merged. |
Collaborator
|
Great! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't merge yet, this requires a new version of TableTraitsUtils.jl that is not yet merged. Mainly just wanted to let you know that you don't have to fix the integration, I'll take care of it :)