Fixed logic of warning on dimension mismatch#4735
Open
yha wants to merge 3 commits intoJuliaPlots:masterfrom
Open
Fixed logic of warning on dimension mismatch#4735yha wants to merge 3 commits intoJuliaPlots:masterfrom
yha wants to merge 3 commits intoJuliaPlots:masterfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4735 +/- ##
==========================================
+ Coverage 89.96% 90.29% +0.32%
==========================================
Files 40 40
Lines 8383 8729 +346
==========================================
+ Hits 7542 7882 +340
- Misses 841 847 +6
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes spurious warnings when
missing/NaNis at the start or end of input vector, as inAdds stricter checks with warnings in other cases. Tests pass even when these warnings are changed to errors, but I kept them as warnings to be less breaking.
warn_on_attr_dim_mismatchreally shouldn't have anything to do with segments, so maybe it should be called from elsewhere in the pipeline, but I'm not sure where.Attribution