Skip to content

Use smoothstep for lsqfit window blending - #73

Open
elenamarkovic-dev wants to merge 3 commits into
JuliaPhysics:mainfrom
elenamarkovic-dev:use-smoothstep-window
Open

Use smoothstep for lsqfit window blending#73
elenamarkovic-dev wants to merge 3 commits into
JuliaPhysics:mainfrom
elenamarkovic-dev:use-smoothstep-window

Conversation

@elenamarkovic-dev

Copy link
Copy Markdown

Fixes #70.

This changes lsqfitatpos window blending to use the existing _smoothstep helper instead of a linear fractional weight. The smoother weight was already present as dead/commented code, so this restores the intended smooth transition between neighboring fit windows.

I also added a focused regression test that compares the public lsqfitatpos result against smoothstep-weighted left/right least-squares fits and checks that it differs from the old linear blend.

Checks:

  • git diff --check
  • Full Julia test suite not run locally because Julia is not installed in the execution environment.

@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.44%. Comparing base (5ced5cc) to head (42e4879).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   57.38%   62.44%   +5.06%     
==========================================
  Files          26       26              
  Lines         901      900       -1     
==========================================
+ Hits          517      562      +45     
+ Misses        384      338      -46     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_smoothstep is dead code, lsqfitatpos uses linear window blending

1 participant