Use smoothstep for lsqfit window blending - #73
Open
elenamarkovic-dev wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 57.38% 62.44% +5.06%
==========================================
Files 26 26
Lines 901 900 -1
==========================================
+ Hits 517 562 +45
+ Misses 384 338 -46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70.
This changes lsqfitatpos window blending to use the existing _smoothstep helper instead of a linear fractional weight. The smoother weight was already present as dead/commented code, so this restores the intended smooth transition between neighboring fit windows.
I also added a focused regression test that compares the public lsqfitatpos result against smoothstep-weighted left/right least-squares fits and checks that it differs from the old linear blend.
Checks: