Repository navigation
Conversation
The ELF/Mach-O/PE audit cannot read wasm and passed vacuously. Check that each archive member is a wasm object of the platform's memory model, and flag shared libraries and constructors. On wasm platforms the wrapper declares a library product as a path: there is nothing to dlopen(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
audit_wasmruns for wasm platforms and checks:.amember is a wasm object;memory64intarget_featuresexactly when the arch iswasm64;init_funcs) are flagged;.sofiles are flagged, sincedylink.0is not a stable ABI.It parses
arand the wasm sections directly, with no ObjectFile.jl change.JLL wrappers for a wasm platform declare a
LibraryProductas a path (@declare_file_product/@init_file_product). An archive is neverdlopened.Why
Julia programs compiled to WebAssembly (e.g. with WasmCodegen.jl) link wasm archives from JLLs.
Today the audit passes vacuously on wasm. ObjectFile.jl can't read it, and only executables and
.so/.dylib/.dllfiles are inspected. So a wasm32 archive shipped as wasm64, or a host object inside a wasm archive, goes unnoticed.Depends on JuliaPackaging/BinaryBuilderBase.jl#509, for
iswasmand the wasmLibraryProductlocating.Precedent
The riscv64 rollout: #1355–#1368.
Tests run
test/wasm.jlpasses 10/10 on Julia 1.13.2, with the Base and BinaryBuilderBase changes. It runs against real PCRE2 10.46 archives from JuliaPackaging/Yggdrasil#15468, given inWASM_ARCHIVES. It checks:It skips without the archives. The rest of the suite was not run locally.
Open questions
🤖 Generated with Claude Code