Repository navigation
Never set maintainer_can_modify=false - #1448
Merged
Merged
Conversation
Octogonapus
reviewed
Aug 27, 2026
| # It's undocumented, but `maintainer_can_modify=true` appears to be always | ||
| # invalid in update PR requests, causing the error | ||
| # Fork collab can only be enabled on cross-repo pull requests | ||
| params["maintainer_can_modify"] = false |
Member
There was a problem hiding this comment.
It's not documented but my read here is that true is valid only on cross-repo PRs. If this code is always used for same-repo PRs (within General) then this seems correct.
Member
There was a problem hiding this comment.
Though I would err on the side of passing this in
BinaryBuilder.jl/src/AutoBuild.jl
Line 699 in 76b5f0f
Member
There was a problem hiding this comment.
Official advice from github is actually to omit maintainer_can_modify entirely from same-repo PRs
maintainer_can_modify=false in update PR requestsmaintainer_can_modify=false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.