Skip to content

Never set maintainer_can_modify=false - #1448

Merged
giordano merged 4 commits into
masterfrom
giordano-patch-1
Sep 3, 2026
Merged

giordano merged 4 commits into
masterfrom
giordano-patch-1

Conversation

@giordano

Copy link
Copy Markdown
Member

No description provided.

@giordano
giordano requested a review from Octogonapus August 27, 2026 15:14
Comment thread src/wizard/github.jl Outdated
# It's undocumented, but `maintainer_can_modify=true` appears to be always
# invalid in update PR requests, causing the error
# Fork collab can only be enabled on cross-repo pull requests
params["maintainer_can_modify"] = false

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not documented but my read here is that true is valid only on cross-repo PRs. If this code is always used for same-repo PRs (within General) then this seems correct.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I would err on the side of passing this in

"maintainer_can_modify" => true,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Official advice from github is actually to omit maintainer_can_modify entirely from same-repo PRs

@giordano giordano changed the title Set maintainer_can_modify=false in update PR requests Never set maintainer_can_modify=false Sep 3, 2026
@giordano
giordano merged commit efc06cb into master Sep 3, 2026
10 checks passed
@giordano
giordano deleted the giordano-patch-1 branch September 3, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants