Skip to content

Fail loudly when the JLL push or registry update did not take effect - #1447

Merged
maleadt merged 1 commit into
masterfrom
tb/verify
Aug 27, 2026
Merged

maleadt merged 1 commit into
masterfrom
tb/verify

Conversation

@maleadt

@maleadt maleadt commented Aug 26, 2026 •

Copy link
Copy Markdown
Member

LibGit2.push does not report reference updates the server refused or failed to apply: the objects are uploaded, the branch stays put, and no error is raised. Registration then built a release and a registry PR on top of the previous wrappers (aws_c_common_jll 1.0.0, 2026-08-26).

  • push_jll_package fetches the remote main after pushing and errors if it is not at the new commit; it now returns that commit.
  • upload_to_github_releases takes a commit and passes it to ghr as -c, so a freshly created release tag targets the wrappers built for it rather than whatever the default branch currently points at.
  • Pkg only logs a failed registry update; update_registry_checked turns that into an error, since a stale registry silently yields wrong wrapper build numbers and registration PR titles.

LibGit2.push can return successfully when the server accepts the objects but rejects the reference update. Fetch the remote main branch after pushing and stop before releasing or registering unless it points at the new wrapper commit.

Pass that commit to ghr when it creates the release tag. Also turn Pkg registry update errors into exceptions so wrapper versions and registration metadata are never computed from a stale General registry.
@maleadt
maleadt marked this pull request as ready for review August 26, 2026 20:38
@maleadt
maleadt requested a review from giordano August 27, 2026 05:05
Comment thread src/AutoBuild.jl Resolved
@maleadt
maleadt merged commit 76b5f0f into master Aug 27, 2026
10 checks passed
@maleadt
maleadt deleted the tb/verify branch August 27, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants