Allow passing in allocs to Woodbury and SymWoodbury#49
Open
rafaqz wants to merge 4 commits intoJuliaLinearAlgebra:masterfrom
Open
Allow passing in allocs to Woodbury and SymWoodbury#49rafaqz wants to merge 4 commits intoJuliaLinearAlgebra:masterfrom
allocs to Woodbury and SymWoodbury#49rafaqz wants to merge 4 commits intoJuliaLinearAlgebra:masterfrom
Conversation
Member
|
I've updated this PR to the latest master, which includes a Julia version bump to 1.10 and updates to a lot of the actions. The tests still fail so the errors would need fixing before this can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a woodbury matrix is used for few or only a single RHS solve, the cost of allocating temp arrays each time is mildly consequential.
This PR allows passing all allocations as an
allocskeyword so they can be reused after updates to U/C/V etc.At the same time I added an extra tmp variable so that the second
ldiv!is non-allocating.Closes #48
TODO: remove allocations in Cp definition