Open
Conversation
Contributor
|
Also, I believe README file needs to be updated; to remove SOR smoother from the future section to the supported smoothers section. |
Member
|
@termi-official Who might be able to help review and get this merged? This is a nice piece of work and I could use it in Circuitscape.jl for sure. I've also invited you to this org. |
Collaborator
Author
|
@Abdelrahman912 will make the review when I am done with the PR. Right now there is still a performance regression which I need to investigate in more detail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smoothers were not really doing what they should do and only worked in specific cases. This PR