Skip to content

fix: make DI compatible with latest Mooncake friendly tangents#1001

Merged
gdalle merged 6 commits intomainfrom
gd/moonbump
Apr 29, 2026
Merged

fix: make DI compatible with latest Mooncake friendly tangents#1001
gdalle merged 6 commits intomainfrom
gd/moonbump

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented Apr 27, 2026

Warning

If previously working code fails after to this release (DifferentiationInterface v0.7.17), a temporary workaround is to pin Mooncake to v0.5.24 in your Project.toml. I've spent some time trying to see if there's a feasible way to protect Mooncake's users from the breakage v0.5.25 is causing, but I don't see a feasible way, so I am lifting the compat bounds and will leave it up to Mooncake to handle this.

Fixes #986 and #996, supersedes #988:

  • Add version-dependent logic to handle Mooncake's friendly tangents
  • Add a set of tests on Mooncake-old (v0.5.24) alongside the latest version
  • Disable static array tests on Mooncake (>=v0.5.25) since they now fail

See also:

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.61%. Comparing base (1b5d91c) to head (74ac5ea).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...MooncakeExt/DifferentiationInterfaceMooncakeExt.jl 0.00% 1 Missing ⚠️
...e/ext/DifferentiationInterfaceMooncakeExt/utils.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1001       +/-   ##
===========================================
+ Coverage   49.37%   90.61%   +41.23%     
===========================================
  Files         127      136        +9     
  Lines        7838     7988      +150     
===========================================
+ Hits         3870     7238     +3368     
+ Misses       3968      750     -3218     
Flag Coverage Δ
DI 88.43% <66.66%> (+57.67%) ⬆️
DIT 96.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gdalle gdalle marked this pull request as ready for review April 28, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changes in Mooncake 0.5.25 that may affect DI users

2 participants