Conversation
aviatesk
force-pushed
the
avi/adjust-59915
branch
from
d4ae7fa to
cf40dc0
Compare
Since JuliaLang/julia#59915, `Base._which` now takes `Compiler.MethodTableView` instead of `MethodTable`, so this change is necessary. However, with this change, it seems that CassetteOverlay and external abstract interpreter packages cannot be composed. If this becomes necessary, we may need to change the interface of `CassetteOverlay.method_table`.
aviatesk
force-pushed
the
avi/adjust-59915
branch
from
cf40dc0 to
c7f2983
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since JuliaLang/julia#59915,
Base._whichnow takesCompiler.MethodTableViewinstead ofMethodTable, so this change is necessary.However, with this change, it seems that CassetteOverlay and external abstract interpreter packages cannot be composed. If this becomes necessary, we may need to change the interface of
CassetteOverlay.method_table.