fix: Fix DeprecationWarning: Module.issuer: Use new ModuleGraph API#423
Open
MalikBen wants to merge 1 commit intoJetBrains:masterfrom
Open
fix: Fix DeprecationWarning: Module.issuer: Use new ModuleGraph API#423MalikBen wants to merge 1 commit intoJetBrains:masterfrom
MalikBen wants to merge 1 commit intoJetBrains:masterfrom
Conversation
f6a598b to
72054fa
Compare
|
checks failed , @MalikBen |
Contributor
|
Looks like test for const isWebpackGreaterThan5 = version[0] >= 5;to const isWebpackGreaterThan5 = version && version[0] >= 5; |
|
ping @MalikBen |
1 similar comment
|
ping @MalikBen |
pbn04001
approved these changes
Mar 15, 2021
|
@pbn04001 can I open a new PR to fix this warning? |
Contributor
|
@b-e-r-t-o Yes, you can |
Author
|
Hi, I'm sorry I was receiving all the e-mails in my spam box, is this issue fixed ? Should I close it ? |
|
For what it's worth, I'm no longer seeing this issue. Probably best to wait until a few others weight in before closing it, though, IMHO 🙂 |
|
Wait, nvm, I was testing with an outdated version of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (bugfix, feature, docs update, improvement)
Removes warning by using ModuleGraph in case of webpack version >= 5
What is the current behavior? (You can also link to an open issue here)
webpack5 build throws a DeprecationWarning
[DEP_WEBPACK_MODULE_ISSUER] DeprecationWarning: Module.issuer: Use new ModuleGraph API
See #418
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills contributing guidelines