JBR-9994 Enable AccessibleAnnouncer for both X11 and Wayland#587
Closed
tanya011 wants to merge 5 commits intoJetBrains:jbr21from
Closed
JBR-9994 Enable AccessibleAnnouncer for both X11 and Wayland#587tanya011 wants to merge 5 commits intoJetBrains:jbr21from
tanya011 wants to merge 5 commits intoJetBrains:jbr21from
Conversation
tanya011
force-pushed
the
accessible-announcer-wayland
branch
from
d515c78 to
14c2e9d
Compare
OnePatchGuy
requested review from
OnePatchGuy and
mkartashev
and removed request for
mkartashev
mkartashev
requested changes
Feb 11, 2026
Member
|
We're considering JBR-10004 as a blocker for this PR, because changes introduced there will most likely conflict with these ones. Let's wait until that task is done and then rebase this PR on top. |
Move AccessibleAnnouncer to shared libawt location and added speech-dispatcher configuration to libawt_wlawt build.
tanya011
force-pushed
the
accessible-announcer-wayland
branch
from
14c2e9d to
b6a35f9
Compare
Member
|
Since JBR-10004 is fixed, let's get back to this PR. |
OnePatchGuy
requested changes
Mar 7, 2026
| include \ | ||
| common/awt/debug \ | ||
| common/awt/systemscale \ | ||
| common/awt/AccessibleAnnouncer \ |
Member
There was a problem hiding this comment.
I don't think we should expose the headers from that directory because they're only supposed to be used by that directory itself. I'd say LIBAWT_XAWT_EXTRA_SRC should be used instead (if needed at all).
…AWT/WLAWT into shared configuration
…id a situation when -DNO_A11Y_SPEECHD_ANNOUNCING doesn't accidentally get added
tanya011
force-pushed
the
accessible-announcer-wayland
branch
from
701b0f9 to
3b7416a
Compare
mkartashev
approved these changes
Mar 9, 2026
OnePatchGuy
requested changes
Mar 10, 2026
tanya011
force-pushed
the
accessible-announcer-wayland
branch
from
1076559 to
21e2f0e
Compare
…bility Move AccessibleAnnouncer to another directory to restrict builds to XAWT and WLAWT
tanya011
force-pushed
the
accessible-announcer-wayland
branch
from
21e2f0e to
0f8b5f3
Compare
OnePatchGuy
approved these changes
Apr 28, 2026
Member
OnePatchGuy
left a comment
OnePatchGuy
left a comment
There was a problem hiding this comment.
Seems working fine, LGTM.
Member
|
The patch has been rebased on top of jbr25 branch and merged into there and main branches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move AccessibleAnnouncer to shared libawt location and added speech-dispatcher configuration to libawt_wlawt build.