Skip to content

Fix recursion test case for Python 3.12 - #19

Open
vtermanis wants to merge 3 commits into
dev-contribfrom
py3.12-compat
Open

Fix recursion test case for Python 3.12#19
vtermanis wants to merge 3 commits into
dev-contribfrom
py3.12-compat

Conversation

@vtermanis

@vtermanis vtermanis commented Oct 20, 2023

Copy link
Copy Markdown
Contributor

- Update pylint.rc or 3.0.1
- Minor code changes for warnings
@yan12125

Copy link
Copy Markdown

Hi, is there anything to do before merging this? Maybe I can help

@kapouer

kapouer commented Apr 22, 2024

Copy link
Copy Markdown

This PR doesn't really fix tests for latest version of python 3.12.
See python/cpython#112282

The simplest way to fix the tests is to not call /setrecursionlimit/, just getrecursionlimit.

@vtermanis

Copy link
Copy Markdown
Contributor Author

The simplest way to fix the tests is to not call /setrecursionlimit/, just getrecursionlimit.

It's not that - there's a good reason why the tests set the limit previously: The test would otherwise take too long to generate the required data or fail with a different error on earlier versions (I believe < 3.4 & 2.7.)

I'm planning to drop support for everything < 3.8 and then indeed no setting should be needed, it appears.

@llimeht

llimeht commented Dec 8, 2025

Copy link
Copy Markdown

There is an additional change in the way Python 3.14 raises recursion errors from C extensions that requires changes here. See https://salsa.debian.org/python-team/packages/py-ubjson/-/blob/debian/master/debian/patches/py314_recursion.patch?ref_type=heads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants