Skip to content

Add NodeToClientV_24 for ValidateTx query #5377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
palas wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Draft

Add NodeToClientV_24 for ValidateTx query #5377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cardano-diffusion/api/lib/Cardano/Network/NodeToClient/Version.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ data NodeToClientVersion
| NodeToClientV_23
-- ^ added @QueryDRepsDelegations@,
-- LedgerPeerSnapshot CBOR encoding contains block hash and NetworkMagic
| NodeToClientV_24
-- ^ added @ValidateTx@ query
deriving (Eq, Ord, Enum, Bounded, Show, Generic, NFData)

-- | We set 16ths bit to distinguish `NodeToNodeVersion` and
Expand All @@ -84,6 +86,7 @@ nodeToClientVersionCodec = CodecCBORTerm { encodeTerm, decodeTerm }
NodeToClientV_21 -> enc 21
NodeToClientV_22 -> enc 22
NodeToClientV_23 -> enc 23
NodeToClientV_24 -> enc 24
where
enc :: Int -> CBOR.Term
enc = CBOR.TInt . (`setBit` nodeToClientVersionBit)
Expand All @@ -98,6 +101,7 @@ nodeToClientVersionCodec = CodecCBORTerm { encodeTerm, decodeTerm }
21 -> Right NodeToClientV_21
22 -> Right NodeToClientV_22
23 -> Right NodeToClientV_23
24 -> Right NodeToClientV_24
n -> Left (unknownTag n)
where
dec :: CBOR.Term -> Either (Text, Maybe Int) Int
Expand Down
2 changes: 2 additions & 0 deletions cardano-diffusion/orphan-instances/Cardano/Network/OrphanInstances.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ instance FromJSON NodeToClientVersion where
Number 21 -> pure NodeToClientV_21
Number 22 -> pure NodeToClientV_22
Number 23 -> pure NodeToClientV_23
Number 24 -> pure NodeToClientV_24
Number x -> fail $ "FromJSON.NodeToClientVersion: unsupported node-to-client protocol version " ++ show x
x -> fail $ "FromJSON.NodeToClientVersion: error parsing NodeToClientVersion: " ++ show x

Expand All @@ -92,6 +93,7 @@ instance ToJSON NodeToClientVersion where
NodeToClientV_21 -> Number 21
NodeToClientV_22 -> Number 22
NodeToClientV_23 -> Number 23
NodeToClientV_24 -> Number 24

instance ToJSON NodeToNodeVersionData where
toJSON (NodeToNodeVersionData (NetworkMagic m) dm ps q) = object
Expand Down