Skip to content

refactor(aggregator): remove the protocol configuration parameters in aggregator configuration - #3510

Draft
turmelclem wants to merge 2 commits into
mainfrom
ctl/3395-remove-the-protocol-configuration-parameters-in-aggregator-configuration
Draft

refactor(aggregator): remove the protocol configuration parameters in aggregator configuration#3510
turmelclem wants to merge 2 commits into
mainfrom
ctl/3395-remove-the-protocol-configuration-parameters-in-aggregator-configuration

Conversation

@turmelclem

@turmelclem turmelclem commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Content

Since the aggregator now reads the configuration parameters from the on-chain markers :

  • Remove the protocol configuration parameters in aggregator configuration (cardano_transactions_signing_config, cardano_blocks_transactions_signing_config, protocol_parameters)
  • Remove the LocalMithrilNetworkConfigurationProvider

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

This PR closes #3395

@turmelclem turmelclem self-assigned this Aug 31, 2026
@turmelclem
turmelclem force-pushed the ctl/3395-remove-the-protocol-configuration-parameters-in-aggregator-configuration branch from 9a9a0b6 to 2371360 Compare August 31, 2026 16:15
@turmelclem turmelclem changed the title Remove the protocol configuration parameters in aggregator configuration refactor(aggregator): remove the protocol configuration parameters in aggregator configuration Aug 31, 2026
@github-actions

Copy link
Copy Markdown

Test Results

     5 files  ± 0     221 suites  ±0   1h 7m 45s ⏱️ + 12m 1s
 3 492 tests  - 13   3 492 ✅  - 13  0 💤 ±0  0 ❌ ±0 
11 573 runs   - 39  11 573 ✅  - 39  0 💤 ±0  0 ❌ ±0 

Results for commit 2371360. ± Comparison against base commit 69572a0.

This pull request removes 13 tests.
mithril-aggregator ‑ configuration::test::can_build_config_with_cardano_blocks_tx_signing_config_from_default_configuration
mithril-aggregator ‑ configuration::test::can_build_config_with_ctx_signing_config_from_default_configuration
mithril-aggregator ‑ configuration::test::get_leader_aggregator_epoch_settings_configuration::fails_when_cardano_blocks_transactions_is_enabled_without_associated_config
mithril-aggregator ‑ configuration::test::get_leader_aggregator_epoch_settings_configuration::fails_when_cardano_transactions_is_enabled_without_associated_config
mithril-aggregator ‑ configuration::test::get_leader_aggregator_epoch_settings_configuration::succeed_when_cardano_blocks_transactions_is_disabled_and_regardless_if_cardano_blocks_transactions_signing_config_is_set
mithril-aggregator ‑ configuration::test::get_leader_aggregator_epoch_settings_configuration::succeed_when_cardano_blocks_transactions_is_enabled_and_cardano_blocks_transactions_signing_config_is_set
mithril-aggregator ‑ configuration::test::get_leader_aggregator_epoch_settings_configuration::succeed_when_cardano_transactions_is_disabled_and_regardless_if_cardano_transactions_signing_config_is_set
mithril-aggregator ‑ configuration::test::get_leader_aggregator_epoch_settings_configuration::succeed_when_cardano_transactions_is_enabled_and_cardano_transactions_signing_config_is_set
mithril-aggregator ‑ services::network_configuration_provider::tests::get_stored_configuration_disable_inconsistent_discriminants_when_fallback
mithril-aggregator ‑ services::network_configuration_provider::tests::get_stored_configuration_disable_inconsistent_discriminants_without_fallback
…

@turmelclem
turmelclem deployed to testing-preview August 31, 2026 16:36 — with GitHub Actions Active
@turmelclem
turmelclem deployed to testing-2-preview August 31, 2026 16:36 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the protocol configuration parameters in aggregator configuration

1 participant