Add support for NodeToClientV_24 and transaction validate integration tests#6582
Draft
palas wants to merge 5 commits into
Draft
Add support for NodeToClientV_24 and transaction validate integration tests#6582palas wants to merge 5 commits into
NodeToClientV_24 and transaction validate integration tests#6582palas wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the new
NodeToClientV_24protocol version and comprehensive integration tests for thetransaction validateCLI command.Part of IntersectMBO/cardano-cli#1380.
Big picture:
transaction validatecurrently appliesapplyTxclient-side with an empty UTxO set, making it unable to properly validate transactions. This cross-repo change adds a newValidateTxquery to theLocalStateQueryprotocol so the node validates transactions against its real ledger state and UTxO set.transaction validatePR list:NodeToClientV_24forValidateTxquery ouroboros-network#5377ValidateTxquery forLocalStateQueryprotocol ouroboros-consensus#2052transaction validatecommand cardano-cli#1386What this PR does
NodeToClientV_24 -> 24tonodeToClientVersionToIntin startup tracersShelleyNodeToClientVersion16to theToJSONorphan instance inOrphanInstances.Shelleyhprop_transaction_validateandhprop_transaction_validate_all_errors) incardano-testnetcovering:ouroboros-consensus,ouroboros-network,cardano-api, andcardano-cliChecklist
See Running tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12