FFI: finish implementing .isa ffi features#147
Open
alastairreid wants to merge 5 commits into
Open
Conversation
In several places, support for foreign types such as enums and for foreign variables was incomplete and did not work if you replaced the configuration json file with the new .isa foreign import/export declarations.
| | AST.Decl_FunFFI (nm, is_export, x, _, _) | ||
| | AST.Decl_VarFFI (nm, is_export, x, _) | ||
| | AST.Decl_TypeFFI (nm, is_export, x, _) | ||
| when is_export == get_exports |
There was a problem hiding this comment.
Suggested change
| when is_export == get_exports | |
| when is_export = get_exports |
Not a bug. But = is better by default (unless you optimize the comparison)
| let new_exports = List.filter_map (fun d -> | ||
| ( match d with | ||
| | AST.Decl_FunFFI (nm, is_export, x, _, _) | ||
| | AST.Decl_VarFFI (nm, is_export, x, _) |
There was a problem hiding this comment.
Decl_VarFFI should be ignored here - it is handled in xform_foreign.ml
Suggested change
| | AST.Decl_VarFFI (nm, is_export, x, _) |
| @@ -680,7 +680,7 @@ let ffi_definition := | |||
| "var"; nm=STRINGLIT; "="; v=path; ";"; | |||
| { Decl_VarFFI(nm, is_export, v, Range($symbolstartpos, $endpos)) } | |||
| | "foreign"; is_export=ffi_direction; | |||
There was a problem hiding this comment.
What if I do foreign import type "E" = E; (import instead of export) by mistake, will it be simply ignored for now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried replacing the config.json files in tests, I found that the new .isa ffi language features were not fully implemented.
So this finishes the implementation (but leaves config.json support in place until others are updated).
See changes in tests for the new .isa way.