fix: Apply comments' suggestions on summary and translation PRs

[Elouan1411]

No description provided.

[Copilot]

Pull request overview

Despite the title suggesting only a comment fix, this PR is a broader cleanup around the AI Summary/Translate flow. It removes the now-unused actionCloseSummaryWindow string in the base locale and 12 translations, renames the Matomo event Summary → Summarize (and updates its single call site), renames AiProcessState.Error.isRetry → isRetryAttempt, adds a GPL license header to ic_paragraph_shorten.xml, reorders operations in getCurrentLanguageCode, simplifies setTranslateUi/setSummaryUi away from with(...), and—most substantially—moves the AI summary/translate state machine (timers, API calls, body updates) from ThreadFragment into ThreadViewModel, surfacing UI updates via a new aiStateUpdates: SingleLiveEvent<AiStateUpdate> and new AiAction/AiBodyUpdate types.

Changes:

• Refactor AI summary/translate logic from ThreadFragment into ThreadViewModel, with retry timers, state map updates and a new AiStateUpdate event consumed by the fragment.
• Rename AiProcessState.Error.isRetry → isRetryAttempt (with adapter updated) and Matomo Summary → Summarize.
• Remove the unused actionCloseSummaryWindow string from base + 12 locale files; add license header to ic_paragraph_shorten.xml; minor tweaks to getCurrentLanguageCode and MailActionsBottomSheetDialog UI setters.

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
app/src/main/res/values/strings.xml	Removes unused actionCloseSummaryWindow base string.
app/src/main/res/values-{da,de,el,es,fi,fr,it,nb,nl,pl,pt,sv}/strings.xml	Removes the corresponding translated actionCloseSummaryWindow entries.
app/src/main/res/drawable/ic_paragraph_shorten.xml	Adds GPL license header.
app/src/main/java/com/infomaniak/mail/utils/extensions/ContextExt.kt	Reorders take(2).lowercase() and trims a trailing blank line.
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadViewModel.kt	Adds AI action orchestration, retry timers, AiStateUpdate event and related enums.
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadState.kt	Renames isRetry → isRetryAttempt on AiProcessState.Error.
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadFragment.kt	Delegates AI flow to the view model and observes aiStateUpdates; drops local timers and helpers.
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadAdapter.kt	Updates AiAction import to the view-model namespace, renames usage to isRetryAttempt, removes stray kotlin.context import.
app/src/main/java/com/infomaniak/mail/ui/main/thread/actions/MessageActionsBottomSheetDialog.kt	Tracks MatomoName.Summarize instead of Summary.
app/src/main/java/com/infomaniak/mail/ui/main/thread/actions/MailActionsBottomSheetDialog.kt	Rewrites setTranslateUi/setSummaryUi without with(...).
app/src/main/java/com/infomaniak/mail/MatomoMail.kt	Renames Matomo enum entry Summary("summary") → Summarize("summarize").

Comments suppressed due to low confidence (1)

app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadFragment.kt:294

• After the refactor, onDestroyView no longer does any AI-related cleanup, but a stray blank line was left at the start of the method body. Please remove it to match the style of the surrounding overrides.

    override fun onDestroyView() {

        threadAdapter.resetCallbacks()
        super.onDestroyView()
        _binding = null

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[FabianDevel]

Suggested change

	AiAction.SUMMARY -> ThreadAdapter.NotifyType.AiSummaryStateChanged
	AiAction.TRANSLATE -> ThreadAdapter.NotifyType.AiTranslateStateChanged
	AiAction.SUMMARY -> NotifyType.AiSummaryStateChanged
	AiAction.TRANSLATE -> NotifyType.AiTranslateStateChanged

[FabianDevel]

We'll need to extract the whole code of your actions to another viewModel 'AiActionsViewModel' or to a manager

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tevincent]

Why changing that ?

[tevincent]

It's the same ... right ?

[tevincent]

You mean hasAlreadyRetried ?