fix: Remove actions on draft#2916
Open
Elouan1411 wants to merge 11 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the mail action menus and swipe behaviors to remove/disable unsupported actions when the current item/folder is a Draft, ensuring users don’t see actions that don’t apply to drafts.
Changes:
- Hide thread/message bottom-sheet actions (archive, favorite, spam, move, main actions, etc.) when the item is in Draft.
- Hide multi-select main actions/favorite/phishing and ensure spam action is hidden for Draft.
- Override swipe actions in Draft context (fixed actions: delete / quick-actions menu) and disable archive quick-action in multi-selection for drafts.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/java/com/infomaniak/mail/ui/main/thread/actions/ThreadActionsBottomSheetDialog.kt | Detect Draft role and hide spam + several action groups for draft threads. |
| app/src/main/java/com/infomaniak/mail/ui/main/thread/actions/MultiSelectBottomSheetDialog.kt | Hide main actions/favorite/phishing for Draft multi-select; reuse shared spam hiding. |
| app/src/main/java/com/infomaniak/mail/ui/main/thread/actions/MessageActionsBottomSheetDialog.kt | Detect Draft role and hide multiple actions for draft messages. |
| app/src/main/java/com/infomaniak/mail/ui/main/thread/actions/MailActionsBottomSheetDialog.kt | Add helpers to hide specific action rows when in Draft; adjust archive/favorite APIs. |
| app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListMultiSelection.kt | Disable archive quick-action when selection is from Draft (or Archive). |
| app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListFragment.kt | Force Draft swipe actions to Delete / Quick-actions menu and show appropriate disabled/enabled UI. |
| app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListAdapter.kt | Attempt to set Draft swipe UI visuals during dynamic swipe icon updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Elouan1411
force-pushed
the
remove-actions-on-draft
branch
from
ae5104d to
154bdad
Compare
Elouan1411
force-pushed
the
remove-actions-on-draft
branch
2 times, most recently
from
b0b2a19 to
65d696b
Compare
solrubado
requested changes
Jun 2, 2026
Elouan1411
force-pushed
the
remove-actions-on-draft
branch
from
9d4c197 to
55eecf5
Compare
Elouan1411
force-pushed
the
remove-actions-on-draft
branch
3 times, most recently
from
62e1bc6 to
4922fd5
Compare
FabianDevel
requested changes
Jun 2, 2026
Elouan1411
force-pushed
the
remove-actions-on-draft
branch
from
4922fd5 to
04c3667
Compare
FabianDevel
requested changes
Jun 2, 2026
FabianDevel
requested changes
Jun 3, 2026
Elouan1411
force-pushed
the
remove-actions-on-draft
branch
from
2374c3f to
a106b9c
Compare
…owed in the draft
Elouan1411
force-pushed
the
remove-actions-on-draft
branch
from
a106b9c to
e087d5e
Compare
|
FabianDevel
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.