feat(pki): pqc readiness pie + trend chart and inventory preset views #6084
Claude / Claude Code Review
completed
Apr 17, 2026 in 7m 20s
Code review found 1 important issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | frontend/src/hooks/api/certificates/constants.tsx:46-69 |
ECDSA_P521 missing from certKeyAlgorithms dropdown array |
Annotations
Check failure on line 69 in frontend/src/hooks/api/certificates/constants.tsx
claude / Claude Code Review
ECDSA_P521 missing from certKeyAlgorithms dropdown array
The `certKeyAlgorithms` array in `frontend/src/hooks/api/certificates/constants.tsx` is missing an entry for `ECDSA_P521`, so users cannot select EC P521 from algorithm-selection dropdowns in CA creation, certificate policy forms, and KMIP client certificate modals. Add `{ label: certKeyAlgorithmToNameMap[CertKeyAlgorithm.ECDSA_P521], value: CertKeyAlgorithm.ECDSA_P521 }` after the `ECDSA_P384` entry to restore selectability.
Loading