Skip to content

improvement: add rotation icon to rotated secrets in single env display#6053

Open
scott-ray-wilson wants to merge 2 commits intomainfrom
SECRETS-213
Open

improvement: add rotation icon to rotated secrets in single env display#6053
scott-ray-wilson wants to merge 2 commits intomainfrom
SECRETS-213

Conversation

@scott-ray-wilson
Copy link
Copy Markdown
Contributor

Context

This PR adds a rotation icon to rotated secrets in the single env view of the secrets overview page

Screenshots

CleanShot 2026-04-16 at 12 11 31@2x

Steps to verify the change

  • look

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Updated CLAUDE.md files (if needed)
  • Read the contributing guide

@linear
Copy link
Copy Markdown

linear bot commented Apr 16, 2026

@maidul98
Copy link
Copy Markdown
Collaborator

maidul98 commented Apr 16, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 158f218649

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

adilsitos
adilsitos previously approved these changes Apr 16, 2026
Copy link
Copy Markdown
Contributor

@adilsitos adilsitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working, but maybe one thing that we could have is to keep these secrets closer to the rotation (?) it feels a little bit confusing for me which rotation is taking care of these secrets.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants