Skip to content

fix(scim): toggle deleteScimToken modal state on close#6006

Open
syedmazharaliraza wants to merge 1 commit intoInfisical:mainfrom
syedmazharaliraza:fix/scim-delete-modal-popup-key
Open

fix(scim): toggle deleteScimToken modal state on close#6006
syedmazharaliraza wants to merge 1 commit intoInfisical:mainfrom
syedmazharaliraza:fix/scim-delete-modal-popup-key

Conversation

@syedmazharaliraza
Copy link
Copy Markdown
Contributor

Context

This fixes a modal state wiring bug in SCIM token deletion flow.

Problem

When closing the Delete SCIM token confirmation modal (click outside / Esc), the code was toggling the wrong popup key:

  • It toggled scimToken (parent modal)
  • Instead of deleteScimToken (child delete modal)

Impact before

  • Parent Manage SCIM credentials modal could close unexpectedly.
  • Delete modal state could become inconsistent and feel flaky.

Behavior now

  • Closing/opening the delete confirmation modal updates only deleteScimToken state.
  • Parent SCIM modal stays stable unless explicitly closed.

Change

  • File: frontend/src/pages/organization/SettingsPage/components/OrgProvisioningTab/ScimTokenModal.tsx
  • Updated:
    • handlePopUpToggle("scimToken", isOpen)
    • to handlePopUpToggle("deleteScimToken", isOpen)

Screen Recordings

Before After
Screen.Recording.2026-04-13.at.2.34.59.AM.mov
Screen.Recording.2026-04-13.at.2.40.49.AM.mov

Steps to verify the change

  1. Go to Organization Settings -> Provisioning.
  2. Click Configure in the SCIM section.
  3. In SCIM Tokens, click delete (X) on any token.
  4. Close the delete modal using click-outside or Esc.
  5. Verify:
    • Delete modal closes correctly.
    • Parent Manage SCIM credentials modal remains open.
  6. Re-open delete modal and confirm delete flow still works.

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: fix(scim): toggle deleteScimToken modal state on close
  • Tested locally
  • Updated docs (if needed)
  • Updated CLAUDE.md files (if needed)
  • Read the contributing guide

If you want, I can also give you a version with real <source type="video/mp4"> tags (GitHub-safe fallback format).

Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@maidul98
Copy link
Copy Markdown
Collaborator

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants