feat(send): dynamically estimate and disclose network fee based on network stats (#458) - #582
Merged
Nanafancy merged 1 commit intoAug 31, 2026
Conversation
|
@xtep103 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Replaces the hardcoded
0.00001 XLMnetwork fee with dynamic fee estimation based on real-time Stellar network conditions (via Horizon/fee_stats) and transaction complexity (operation count).Related Issue
Closes #458
Changes
Send Feature & Fee Estimation
ignition-pay-frontend/features/send/services/fee.tsfetchNetworkFeeStatsto query/fee_statsfrom Horizon with graceful fallback to standard 100 stroops (0.00001 XLM) on network/server error or timeout.estimateTransactionFeeto compute dynamic fees by combining network fee stats with transaction complexity (operation count).ignition-pay-frontend/features/send/models/index.tscalculateTransactionFee,BASE_FEE_STROOPS,STROOPS_PER_XLM,DEFAULT_NETWORK_FEE_XLM, andNetworkFeeEstimateinterface.spendableBalanceandvalidateAmountto accept dynamic custom fee parameters for native XLM transactions.ignition-pay-frontend/features/send/services/index.tsignition-pay-frontend/features/send/widgets/SendPage.tsx0.00001 XLM.ignition-pay-frontend/components/transaction-row.tsxignition-pay-frontend/tests/send-fee.test.tscalculateTransactionFee,fetchNetworkFeeStats, andestimateTransactionFee.ignition-pay-frontend/tests/send-models.test.tsspendableBalanceandvalidateAmount.ignition-pay-frontend/tests/send-page-fee.test.tsxSendPagereview step.Verification Results
/fee_statscalculateTransactionFee0.00001 XLMSendPagereview and confirmed screensspendableBalanceandvalidateAmount