fix: replace mock trustline check with Horizon/backend queries - #580
Open
Marvy54 wants to merge 5 commits into
Open
fix: replace mock trustline check with Horizon/backend queries#580Marvy54 wants to merge 5 commits into
Marvy54 wants to merge 5 commits into
Conversation
|
@Marvy54 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR replaces the mocked
checkTrustlineimplementation in the send flow with a real trustline verification service. It queries Horizon for the account’s trustlines and falls back to the configured backend API when needed, ensuring users get accurate trustline status before sending assets.Related Issue
Closes: Trustline check uses mock service
Changes
🔍 Real Trustline Verification
[MODIFY]
features/send/services/trustline_service.dartcheckTrustlinelogic; add a network-based implementation that queries Horizon for trustlines.[MODIFY]
.env.exampleHORIZON_URLandTRUSTLINE_BACKEND_URLenvironment variables for configuring the trustline check endpoints.[MODIFY]
examples/dart-wallet/basic-wallet/main.dart[MODIFY]
examples/dart-wallet/basic-wallet/pubspec.yamlhttpdependency required for the network-backed trustline service.[MODIFY]
examples/ts-backend/stellar-api-server/src/index.ts/trustlineendpoint that verifies trustlines via Horizon and returns a normalized JSON response for the Flutter client.Verification Results
checkTrustlinequeries Horizon instead of returning simulated results.env.exampleCloses #455