Skip to content

jhbuild: Add wpe-platform-gtk module#223

Open
TingPing wants to merge 1 commit intomainfrom
wpe-platform-gtk
Open

jhbuild: Add wpe-platform-gtk module#223
TingPing wants to merge 1 commit intomainfrom
wpe-platform-gtk

Conversation

@TingPing
Copy link
Copy Markdown
Member

For testing and developing wpe-platform

For testing and developing wpe-platform
Copy link
Copy Markdown
Collaborator

@clopez clopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another question:
How this module is expected to be used from jhbuild?
Do you need to install first wpe on a path and then build this module?

<meson id="wpe-platform-gtk">
<branch repo="github.com"
module="Igalia/wpe-platform-gtk.git"/>
<!-- This depends on gtk4, but the older distro provided version is fine. -->
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<dependencies>
 <dep package="gtk4"/>
<dependencies>

Why you don't add that this instead of the comment?

We are building gtk4 inside the jhbuild, we don't use the distro provided one, so adding the dep entry on jhbuild is needed to ensure proper order of building

@TingPing
Copy link
Copy Markdown
Member Author

Do you need to install first wpe on a path and then build this module?

Yeah that's what I've been doing

@nikolaszimmermann
Copy link
Copy Markdown
Member

@TingPing / @clopez any concerns left to discuss?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants