Deprecate environment variable WEBKIT_BUILD_USE_SYSTEM_LIBRARIES.#222
Open
clopez wants to merge 1 commit intoIgalia:mainfrom
Open
Deprecate environment variable WEBKIT_BUILD_USE_SYSTEM_LIBRARIES.#222clopez wants to merge 1 commit intoIgalia:mainfrom
clopez wants to merge 1 commit intoIgalia:mainfrom
Conversation
Member
|
You can't immediately remove this because of a change from 10 hours ago. People will be building the past few years of commits inside the sdk. |
Collaborator
Author
mmmm, good point. then let's keep it but add a note about it being deprecated |
Collaborator
Author
|
I have also marked WebKit/WebKit#60862 as suggested to be backported to 2.50 and 2.52 |
This is not longer needed since https://commits.webkit.org/309557@main The env var used by the WebKit tooling to identify if is running inside the SDK is now WEBKIT_CONTAINER_SDK. However, to allow building older versions of WebKit with the SDK, instead of just removing the variable now, add a comment about the deprecation status with the idea of removing it on the future.
clopez
force-pushed
the
delete_WEBKIT_BUILD_USE_SYSTEM_LIBRARIES
branch
from
6c862d4 to
5bff5d2
Compare
clopez
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not longer needed since https://commits.webkit.org/309557@main
The env var used by the WebKit tooling to identify if is running inside the SDK is now
WEBKIT_CONTAINER_SDK.However, to allow building older versions of WebKit with the SDK, instead of just removing the variable now, add a comment about the deprecation status with the idea of removing it on the future.