Preliminary pg upsert support#57
Open
zealot128 wants to merge 1 commit into
Open
Conversation
Member
|
@zealot128 if you wouldn't mind rebasing master and getting a green build, we can finally merge this 😅 |
Author
Squashed rebase is pushed. Let me know if there are any other issues. |
Member
|
looks like there is one legitimate exception: makes sense. can you fix the spec? otherwise i may be able to help at some point. |
- Ignore virtual attributes (ActsAsTaggable...) on serialization
Member
|
fyi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented two ways,
1. "naive upsert" for pg < 9.5
insert into, on exception update all the things.
2. real upsert since 9.5
INSERT INTO .... ON CONFLICT id DO UPDATE SET ...
Also included a fix for exporting ActsAsTaggableOn - AATO adds it's own "tag_list" as a virtual attribute into the
record.attributes, thus, is included in the "INSERT" statement.The ac88b32 fixes that problem by comparing the attributes with column_names.
Would be nice if some user PG user would test it...