Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
<SystemDependencyVersion>10.0.5</SystemDependencyVersion>
<SystemDependencyVersion>10.0.6</SystemDependencyVersion>
</PropertyGroup>
<ItemGroup>
<GlobalPackageReference Include="Nerdbank.GitVersioning" Version="3.9.50" />
Expand Down
1 change: 1 addition & 0 deletions src/Humanizer.Analyzers/Humanizer.Analyzers.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="System.Collections.Immutable" VersionOverride="10.0.6" />
<None Include="$(OutputPath)\$(AssemblyName).dll" Pack="true" PackagePath="analyzers/dotnet/roslyn$(RoslynVersion)/cs" Visible="false" />
</ItemGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.14.0" PrivateAssets="all" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="5.3.0" PrivateAssets="all" />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Align Roslyn package versions to avoid NU1605

Updating Microsoft.CodeAnalysis.CSharp to 5.3.0 here makes this project depend on Microsoft.CodeAnalysis.Analyzers >= 5.3.0-2.*, but src/Humanizer.SourceGenerators/Humanizer.SourceGenerators.csproj still pins Microsoft.CodeAnalysis.Analyzers to 3.11.0 on the next line; with TreatWarningsAsErrors=true in Directory.Build.props, that downgrade is promoted from NU1605 warning to a restore/build error. This means the Humanizer.SourceGenerators build can fail consistently until the analyzer package version is brought into a compatible range (or the explicit pin is removed).

Useful? React with 👍 / 👎.

<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.11.0" PrivateAssets="all" />
<PackageReference Include="System.Text.Json" Version="10.0.5" PrivateAssets="all" />
</ItemGroup>
Expand Down
Loading