Skip to content

Fix ToMetric() rounding boundary issue for doubles #1695 #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reabr wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix ToMetric() rounding boundary issue for doubles #1695 #1696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8079ca
Fix ToMetric rounding boundary issue for doubles
reabr Mar 28, 2026
53ee062
Fix ToMetric rounding: use Equals(0d) check #1695
reabr Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/Humanizer/MetricNumeralExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,16 @@ static string BuildRepresentation(double input, MetricNumeralFormats? formats, i
return BuildMetricRepresentation(input, exponent, formats, decimals);
}

if (decimals.HasValue)
{
var rounded = Math.Round(input, decimals.Value);
if (!rounded.Equals(0d))
{
var roundedExponent = (int)Math.Floor(Math.Log10(Math.Abs(rounded)) / 3);
if (!roundedExponent.Equals(0))
return BuildMetricRepresentation(rounded, roundedExponent, formats, decimals);
}
}
var representation = decimals.HasValue
? Math
.Round(input, decimals.Value)
Expand Down
5 changes: 5 additions & 0 deletions tests/Humanizer.Tests/MetricNumeralTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,11 @@ public void TestAllSymbolsAsLong(long subject, int? decimals, string expected) =
[InlineData("1 milli", 1E-3, MetricNumeralFormats.WithSpace | MetricNumeralFormats.UseName, null)]
[InlineData("1 thousandth", 1E-3, MetricNumeralFormats.WithSpace | MetricNumeralFormats.UseShortScaleWord, null)]
[InlineData("1 thousandth", 1E-3, MetricNumeralFormats.WithSpace | MetricNumeralFormats.UseLongScaleWord, null)]
[InlineData("1k", 999.9, null, 0)]
[InlineData("-1k", -999.9, null, 0)]
[InlineData("1k", 999.99, null, 1)]
[InlineData("1M", 999949.9, null, 0)]
[InlineData("999", 999.4, null, 0)]
public void ToMetric(string expected, double input, MetricNumeralFormats? format, int? decimals) =>
Assert.Equal(expected, input.ToMetric(format, decimals));

Expand Down
Loading