Possessivize#1580
Open
maoalvin wants to merge 5 commits into
Open
Conversation
clairernovotny
requested changes
Jul 30, 2025
clairernovotny
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution!
Aside from the minor enumeration value casing, how would this work for languages other than English?
| Plural = 1, | ||
| CouldBeEither = 2, | ||
| } | ||
| public enum PossesiveSuffixOverride |
Member
There was a problem hiding this comment.
Please use PascalCase for the enumeration values.
douglasfls
reviewed
Nov 27, 2025
|
|
||
| public string? ToPossessive(string? word, PossesiveSuffixOverride? possessiveSuffix) | ||
| { | ||
| if (word == null || string.IsNullOrWhiteSpace(word)) |
There was a problem hiding this comment.
Suggested change
| if (word == null || string.IsNullOrWhiteSpace(word)) | |
| if (string.IsNullOrWhiteSpace(word)) |
Null check is already done by string.IsNullOrWhiteSpace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a checklist you should tick through before submitting a pull request:
mainbranch (more info below)build.cmdorbuild.ps1and ensure there are no test failures