Skip to content

Add cohort health board breakdown commands (final-list + build tree)#2367

Closed
mtinti wants to merge 5 commits into
HicServices:developfrom
mtinti:feature/cohort-healthboard-breakdown
Closed

Add cohort health board breakdown commands (final-list + build tree)#2367
mtinti wants to merge 5 commits into
HicServices:developfrom
mtinti:feature/cohort-healthboard-breakdown

Merge branch 'HicServices:develop' into feature/cohort-healthboard-br…

69c502e
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Jul 1, 2026 in 9s

13 new alerts

New alerts in code changed by this pull request

  • 7 warnings
  • 6 notes

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 58 in Rdmp.Core.Tests/CohortCreation/CohortBuildHealthBoardBreakdownTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning test

Disposable 'DataTable' is created but not disposed.

Check warning on line 58 in Rdmp.Core.Tests/CohortCreation/HealthBoardBreakdownReportTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning test

Disposable 'DataTable' is created but not disposed.

Check warning on line 157 in Rdmp.Core.Tests/CohortCreation/HealthBoardBreakdownReportTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning test

Disposable 'DataTable' is created but not disposed.

Check warning on line 239 in Rdmp.Core.Tests/CohortCreation/HealthBoardBreakdownReportTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning test

Disposable 'DataTable' is created but not disposed.

Check warning on line 251 in Rdmp.Core.Tests/CohortCreation/HealthBoardBreakdownReportTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning test

Disposable 'DataTable' is created but not disposed.

Check warning on line 166 in Rdmp.Core/CommandExecution/AtomicCommands/ExecuteCommandExportCohortBuildHealthBoardBreakdown.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning

There is no need to upcast from
null
Loading
to
Nullable
Loading
- the conversion can be done implicitly.

Check warning on line 106 in Rdmp.Core/CommandExecution/AtomicCommands/ExecuteCommandExportCohortHealthBoardBreakdown.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning

Disposable 'DataTable' is created but not disposed.

Check notice on line 205 in Rdmp.Core.Tests/CohortCreation/CohortBuildHealthBoardBreakdownTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed 'readonly' opportunity Note test

Field '_percent' can be 'readonly'.

Check notice on line 221 in Rdmp.Core.Tests/CohortCreation/CohortBuildHealthBoardBreakdownTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed opportunity to use Select Note test

This foreach loop immediately
maps its iteration variable to another variable
Loading
- consider mapping the sequence explicitly using '.Select(...)'.

Check notice on line 220 in Rdmp.Core.Tests/CohortCreation/HealthBoardBreakdownReportTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed opportunity to use Select Note test

This foreach loop immediately
maps its iteration variable to another variable
Loading
- consider mapping the sequence explicitly using '.Select(...)'.

Check notice on line 84 in Rdmp.Core/CohortCreation/HealthBoardBreakdownReport.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed ternary opportunity Note

Both branches of this 'if' statement write to the same variable - consider using '?' to express intent better.

Check notice on line 136 in Rdmp.Core/CommandExecution/AtomicCommands/ExecuteCommandExportCohortBuildHealthBoardBreakdown.cs

See this annotation in the file changed.

Code scanning / CodeQL

Call to 'System.IO.Path.Combine' may silently drop its earlier arguments Note

Call to 'System.IO.Path.Combine' may silently drop its earlier arguments.

Check notice on line 89 in Rdmp.Core/CommandExecution/AtomicCommands/ExecuteCommandExportCohortHealthBoardBreakdown.cs

See this annotation in the file changed.

Code scanning / CodeQL

Call to 'System.IO.Path.Combine' may silently drop its earlier arguments Note

Call to 'System.IO.Path.Combine' may silently drop its earlier arguments.