fix(ci): make cli_tests.yml a valid workflow#900
Open
aiSynergy37 wants to merge 1 commit intoHelixDB:mainfrom
Open
fix(ci): make cli_tests.yml a valid workflow#900aiSynergy37 wants to merge 1 commit intoHelixDB:mainfrom
aiSynergy37 wants to merge 1 commit intoHelixDB:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli_tests.ymlworkflow with a valid workflow definitionworkflow_dispatch+ a placeholder job so GitHub no longer reports parser failures likeNo event triggers defined in onWhy
PRs were receiving workflow failure notifications even when no jobs could run because the workflow file had no valid
onsection.Note
This intentionally keeps CLI tests disabled for automatic PR triggers; it only fixes workflow validity/noise.
Greptile Summary
This PR fixes a GitHub Actions parser failure caused by
cli_tests.ymlbeing entirely commented out, leaving no validon:trigger. The file is replaced with a minimal valid workflow (workflow_dispatch+ a no-op placeholder job) so GitHub no longer reports parse errors on PRs, while keeping CLI tests disabled for automatic triggers.Important Files Changed
workflow_dispatchand a placeholder no-op job to silence GitHub Actions parser errors.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[GitHub detects cli_tests.yml] --> B{Valid on: trigger?} B -- "Before (all commented out)" --> C[Parser Error: No event triggers defined] C --> D[Workflow failure notification on PRs] B -- "After (workflow_dispatch)" --> E[Workflow is valid] E --> F{Triggered manually?} F -- Yes --> G[Run noop placeholder job] G --> H[echo message and exit] F -- No --> I[Workflow not triggered on PRs] I --> J[No spurious failure notifications]Reviews (1): Last reviewed commit: "fix(ci): make cli_tests workflow valid t..." | Re-trigger Greptile