Skip to content

fix(upsert): skip redundant writes on idempotent upsert_e and upsert_v #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keithf123r wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(upsert): skip redundant writes on idempotent upsert_e and upsert_v #888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6413d84
fix(upsert): skip redundant edge writes when props unchanged
keithf123r Mar 20, 2026
b3073f0
test(upsert): regression tests for edge/vector no-op upserts
keithf123r Mar 20, 2026
855d1e4
fix(upsert): skip redundant property merge in VectorNodeWithoutVector…
keithf123r Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
187 changes: 187 additions & 0 deletions helix-db/src/helix_engine/tests/traversal_tests/upsert_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,112 @@ fn test_upsert_e_updates_existing_edge_with_properties() {
txn.commit().unwrap();
}

#[test]
fn test_upsert_e_noop_when_all_properties_identical() {
let (_temp_dir, storage) = setup_test_db();
let arena = Bump::new();
let mut txn = storage.graph_env.write_txn().unwrap();

let node1 = G::new_mut(&storage, &arena, &mut txn)
.add_n("person", None, None)
.collect::<Result<Vec<_>, _>>()
.unwrap()[0]
.id();
let node2 = G::new_mut(&storage, &arena, &mut txn)
.add_n("person", None, None)
.collect::<Result<Vec<_>, _>>()
.unwrap()[0]
.id();

let existing_edge = G::new_mut(&storage, &arena, &mut txn)
.add_edge(
"relates",
props_option(&arena, props!("kind" => "friend", "weight" => 2)),
node1,
node2,
false,
false,
)
.collect::<Result<Vec<_>, _>>()
.unwrap()
.into_iter()
.next()
.unwrap();

let edge_id = if let TraversalValue::Edge(ref e) = existing_edge {
e.id
} else {
panic!("Expected edge");
};

let result = G::new_mut_from_iter(&storage, &mut txn, std::iter::once(existing_edge), &arena)
.upsert_e(
"relates",
node1,
node2,
&[("kind", Value::from("friend")), ("weight", Value::from(2))],
)
.collect::<Result<Vec<_>, _>>()
.unwrap();

assert_eq!(result.len(), 1);
if let TraversalValue::Edge(edge) = &result[0] {
assert_eq!(edge.id, edge_id);
assert_eq!(edge.label, "relates");
assert_eq!(edge.get_property("kind").unwrap(), &Value::from("friend"));
assert_eq!(edge.get_property("weight").unwrap(), &Value::from(2));
} else {
panic!("Expected edge");
}
txn.commit().unwrap();
}

#[test]
fn test_upsert_e_noop_when_no_properties_and_empty_props() {
let (_temp_dir, storage) = setup_test_db();
let arena = Bump::new();
let mut txn = storage.graph_env.write_txn().unwrap();

let node1 = G::new_mut(&storage, &arena, &mut txn)
.add_n("person", None, None)
.collect::<Result<Vec<_>, _>>()
.unwrap()[0]
.id();
let node2 = G::new_mut(&storage, &arena, &mut txn)
.add_n("person", None, None)
.collect::<Result<Vec<_>, _>>()
.unwrap()[0]
.id();

let existing_edge = G::new_mut(&storage, &arena, &mut txn)
.add_edge("plain", None, node1, node2, false, false)
.collect::<Result<Vec<_>, _>>()
.unwrap()
.into_iter()
.next()
.unwrap();

let edge_id = if let TraversalValue::Edge(ref e) = existing_edge {
e.id
} else {
panic!("Expected edge");
};

let result = G::new_mut_from_iter(&storage, &mut txn, std::iter::once(existing_edge), &arena)
.upsert_e("plain", node1, node2, &[])
.collect::<Result<Vec<_>, _>>()
.unwrap();

assert_eq!(result.len(), 1);
if let TraversalValue::Edge(edge) = &result[0] {
assert_eq!(edge.id, edge_id);
assert!(edge.properties.is_none());
} else {
panic!("Expected edge");
}
txn.commit().unwrap();
}

#[test]
fn test_upsert_e_with_defaults_applies_on_create_and_explicit_wins() {
let (_temp_dir, storage) = setup_test_db();
Expand Down Expand Up @@ -896,6 +1002,87 @@ fn test_upsert_v_updates_existing_vector_with_properties() {
txn.commit().unwrap();
}

#[test]
fn test_upsert_v_noop_when_all_properties_identical() {
let (_temp_dir, storage) = setup_test_db();
let arena = Bump::new();
let mut txn = storage.graph_env.write_txn().unwrap();

let query = [0.1_f64, 0.2, 0.3];
let existing_vector = G::new_mut(&storage, &arena, &mut txn)
.insert_v::<Filter>(
&query,
"embedding",
props_option(
&arena,
props!("model" => "gpt3", "version" => 1, "accuracy" => 0.95),
),
)
.collect::<Result<Vec<_>, _>>()
.unwrap()
.into_iter()
.next()
.unwrap();

let vector_id = existing_vector.id();

let result = G::new_mut_from_iter(&storage, &mut txn, std::iter::once(existing_vector), &arena)
.upsert_v(
&query,
"embedding",
&[
("model", Value::from("gpt3")),
("version", Value::from(1)),
("accuracy", Value::from(0.95)),
],
)
.collect::<Result<Vec<_>, _>>()
.unwrap();

assert_eq!(result.len(), 1);
if let TraversalValue::Vector(vector) = &result[0] {
assert_eq!(vector.id, vector_id);
assert_eq!(vector.get_property("model").unwrap(), &Value::from("gpt3"));
assert_eq!(vector.get_property("version").unwrap(), &Value::from(1));
assert_eq!(vector.get_property("accuracy").unwrap(), &Value::from(0.95));
} else {
panic!("Expected vector");
}
txn.commit().unwrap();
}

#[test]
fn test_upsert_v_noop_when_no_properties_and_empty_props() {
let (_temp_dir, storage) = setup_test_db();
let arena = Bump::new();
let mut txn = storage.graph_env.write_txn().unwrap();

let query = [0.5_f64, 0.6, 0.7];
let existing_vector = G::new_mut(&storage, &arena, &mut txn)
.insert_v::<Filter>(&query, "embedding", None)
.collect::<Result<Vec<_>, _>>()
.unwrap()
.into_iter()
.next()
.unwrap();

let vector_id = existing_vector.id();

let result = G::new_mut_from_iter(&storage, &mut txn, std::iter::once(existing_vector), &arena)
.upsert_v(&query, "embedding", &[])
.collect::<Result<Vec<_>, _>>()
.unwrap();

assert_eq!(result.len(), 1);
if let TraversalValue::Vector(vector) = &result[0] {
assert_eq!(vector.id, vector_id);
assert!(vector.properties.is_none());
} else {
panic!("Expected vector");
}
txn.commit().unwrap();
}

#[test]
fn test_upsert_v_with_defaults_applies_on_create_and_explicit_wins() {
let (_temp_dir, storage) = setup_test_db();
Expand Down
Loading
Loading