fix: preserve signed body association in Python export example - #5807
Open
marcus-campbell wants to merge 1 commit into
Open
fix: preserve signed body association in Python export example#5807marcus-campbell wants to merge 1 commit into
marcus-campbell wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
@marcus-campbell is attempting to deploy a commit to the Helicone Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Related pull request: #4382
Component/Service
Python export example (
examples/export/python)Type of Change
Deployment Notes
Context
fetch_all_signed_bodies()pairs responses in source order with signed-body results in completion order. When requests finish out of order, a body can be written to the wrong response's CSV row. A failed request can also be reported under the wrong response ID.This change carries each response through its signed-body fetch. Each completed body is assigned to the response that supplied its URL, while fetching stays concurrent.
Extra Notes
examples/export/pythonhas no test configuration or adjacent test suite, so I verified the reverse-completion regression with a deterministic local harness.