Skip to content

fix: preserve signed body association in Python export example - #5807

Open
marcus-campbell wants to merge 1 commit into
Helicone:mainfrom
marcus-campbell:fix/python-export-signed-body-order
Open

fix: preserve signed body association in Python export example#5807
marcus-campbell wants to merge 1 commit into
Helicone:mainfrom
marcus-campbell:fix/python-export-signed-body-order

Conversation

@marcus-campbell

Copy link
Copy Markdown

Ticket

Related pull request: #4382

Component/Service

Python export example (examples/export/python)

Type of Change

  • Bug fix

Deployment Notes

  • No special deployment steps required

Context

fetch_all_signed_bodies() pairs responses in source order with signed-body results in completion order. When requests finish out of order, a body can be written to the wrong response's CSV row. A failed request can also be reported under the wrong response ID.

This change carries each response through its signed-body fetch. Each completed body is assigned to the response that supplied its URL, while fetching stays concurrent.

Extra Notes

examples/export/python has no test configuration or adjacent test suite, so I verified the reverse-completion regression with a deterministic local harness.

  • Forced the second request to finish before the first. The previous code swapped the bodies; this change retained the correct response-to-body mapping.
  • Forced the second request to fail first. This change reported the correct response ID.
  • Repeated both cases under Python 3.12 and 3.14.
  • Compiled the complete example under Python 3.12 and 3.14.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@vercel

vercel Bot commented Sep 4, 2026

Copy link
Copy Markdown

@marcus-campbell is attempting to deploy a commit to the Helicone Team on Vercel.

A member of the Team first needs to authorize it.

@marcus-campbell marcus-campbell changed the title fix: preserve signed body association in Python export fix: preserve signed body association in Python export example Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant