Repository navigation
Fix the Switch CI build against port-maintenance libultraship - #765
Draft
Project516 wants to merge 1 commit into
Draft
Project516 wants to merge 1 commit into
Project516 wants to merge 1 commit into
Conversation
…e pinned submodule
Project516
force-pushed
the
fix-switch-ci
branch
from
October 18, 2026 22:17
ffec25f to
f2c4668
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Switch build on
mainfails. CI replaces the pinned libultraship submodule withNet64DD/libultrashipmain-nx, which is based on libultrashipmainrather thanport-maintenance, so the game can't find APIs it uses:This PR points the Switch job at a branch with the Switch code applied on top of the pinned submodule commit (60c9bb7).
Draft until the libultraship side merges. The workflow currently fetches
Project516/libultrashipport-maintenance-switch, which is the branch in Net64DD/libultraship#6. Net64DD/libultraship#5 does the same work in a different way. Once one of them is merged, I'll repoint the Switch job back toNet64DD/libultrashipand mark this ready.Testing: the Switch job passes in Release and Debug, built against
port-maintenance-switchat ecbdf84 (Net64DD/libultraship#6 after its merge-conflict fix): https://github.com/Project516/SpaghettiKart/actions/runs/39170416022