Fix song pickup textbox icons for custom/progressive items.#6770
Open
RaccoonCloud wants to merge 1 commit into
Open
Fix song pickup textbox icons for custom/progressive items.#6770RaccoonCloud wants to merge 1 commit into
RaccoonCloud wants to merge 1 commit into
Conversation
Song note texture is IA8 16x24 but vanilla ITEM_SONG draws as 32x32 RGBA, so the icon garbles on pickup. Routes through ITEM_CUSTOM and the existing VB icon hooks, with warp song colours from the quest screen. Small z_message guard so the note is not stretched to 24x24. Split out from split-songs PR HarbourMasters#6627 for separate review.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Song note texture is IA8 16x24 but vanilla ITEM_SONG draws as 32x32 RGBA, so the icon garbles on pickup. Routes through ITEM_CUSTOM and the existing VB icon hooks, with warp song colours from the quest screen. Small z_message guard so the note is not stretched to 24x24 as it was making a noisy garbled texture.
Split out from split-songs PR #6627 for separate review.
Build Artifacts