Sanitize UTF-8 in spoiler log, hints, and save JSON.#6769
Open
RaccoonCloud wants to merge 1 commit into
Open
Conversation
Non-English option text (curly quotes, accents, etc.) was producing invalid JSON and breaking seed gen/regen on some locales. Strings get run through SohUtils::SanitizeUtf8 before hitting jsonData or save files. Split out from split-songs PR HarbourMasters#6627 for separate review.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Member
|
Looks like this makes sure any utf-8 characters that may have been cut off get removed? |
Member
|
is this a situation where utf16 is getting through on Windows? should be fixing root of issue & ensuring encodings are set to utf8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-English option text (curly quotes, accents, etc.) was producing invalid JSON and breaking seed gen/regen on some locales. Strings get run through SohUtils::SanitizeUtf8 before hitting jsonData or save files.
Split out from split-songs PR #6627 for separate review.
Build Artifacts