Skip to content

Fix [Sail] OnLoadGame hook does not trigger #6729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JD-Spencer wants to merge 1 commit into
base: develop
Choose a base branch
from
+1 −1
Open

Fix [Sail] OnLoadGame hook does not trigger #6729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion soh/soh/Network/Sail/Sail.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ void Sail::RegisterHooks() {
});

COND_HOOK(OnLoadGame, isConnected, [&](int32_t fileNum) {
if (!isConnected || !GameInteractor::IsSaveLoaded())
if (!isConnected)

@serprex serprex Jun 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even isConnected should never be false since it's the condition of the hook

wondering if this is supposed to be blocking things like debug save file etc

return;

nlohmann::json payload;
Expand Down
Loading