优化陶瓦联机反馈提示#6120
Open
CiiLu wants to merge 2 commits into
Open
Conversation
Member
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the feedback confirmation dialog to use a new localization key, terracotta.feedback.desc.update, and introduces a shorter version for the existing terracotta.feedback.desc key across several language files. A critical issue was identified in the Arabic localization file where the original key was renamed but not replaced, potentially leading to a MissingResourceException if the old key is still required by the application.
| terracotta.back=خروج | ||
| terracotta.feedback.title=ملء استمارة التقييم | ||
| terracotta.feedback.desc=مع تحديث HMCL لنواة متعدد اللاعبين، نأمل أن تخصص 10 ثوانٍ لملء استمارة التقييم. | ||
| terracotta.feedback.desc.update=مع تحديث HMCL لنواة متعدد اللاعبين، نأمل أن تخصص 10 ثوانٍ لملء استمارة التقييم. |
Contributor
There was a problem hiding this comment.
此处的修改导致 terracotta.feedback.desc 键在阿拉伯语本地化文件中缺失。这会在运行时导致 MissingResourceException，因为代码中仍然有地方在使用这个键。
您应该像其他本地化文件一样，在重命名此键的同时，添加一个新的 terracotta.feedback.desc 键，其值为通用的反馈提示。
terracotta.feedback.desc=نأمل أن تخصص 10 ثوانٍ لملء استمارة التقييم.
terracotta.feedback.desc.update=مع تحديث HMCL لنواة متعدد اللاعبين، نأمل أن تخصص 10 ثوانٍ لملء استمارة التقييم.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
右侧列表内的是随机展示的，和更新没关系
