fix: 列表工具栏水波纹溢出#6117
Merged
Merged
Conversation
Contributor
CiiLu
commented
May 17, 2026
CiiLu
commented
ToobLac
reviewed
May 17, 2026
ToobLac
approved these changes
May 17, 2026
Member
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements overflow clipping with rounded corners for toolbars across several UI components, including ToolbarListPageSkin, GameListPage, and ModListPageSkin, while also refactoring imports in GameListPage. Review feedback indicates that the value of 8 used for rounded corners likely results in a 4px radius rather than 8px, as JavaFX arc properties represent diameter. Additionally, the reviewer pointed out that calling setOverflowHidden on TransitionPane instances is redundant and creates unnecessary object overhead, suggesting an architectural improvement to handle corner radii within the TransitionPane class itself.
Glavo
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.