[Enhancement] 导出整合包-文件选择优化#6115
Conversation
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the modpack file selection UI and filtering logic, introducing a directory-first sorting mechanism and hierarchical level tracking. However, several issues were identified: setting CheckBoxTreeItem values to empty strings breaks file path construction in the export logic, and the use of substringAfter for labels displays incorrect nested paths. Additionally, performing I/O operations like Files.isDirectory inside a comparator significantly impacts performance, and a redundant match method was introduced in the Modpack class that duplicates existing logic in ModAdviser.
| private static boolean match(List<String> l, String fileName) { | ||
| for (String s : l) { | ||
| if (s.startsWith("regex:")) { | ||
| if (fileName.matches(s.substring("regex:".length()))) | ||
| return true; | ||
| } else { | ||
| if (fileName.equals(s)) | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } |
There was a problem hiding this comment.
此 match 方法与 ModAdviser.match 的逻辑完全重复。既然 Modpack 已经依赖于 ModAdviser，建议删除此冗余方法，并直接调用 ModAdviser.match(blackList, path, false)，以提高代码的可维护性。
There was a problem hiding this comment.
故意拆出来的，防止出问题。本来就应该自己用自己的
2 participants
natives-os-arch文件夹Resolves #6073 Fixes #6116
顺带提一句，电磁炉在 #5367 中的修复是没有问题的，因为所谓“其他地方”都不会传入目录，不会被他的修改影响到。