Skip to content

fix: #5343 陶瓦联机界面账号快速切换列表右侧滚动条错位以及列表莫名抽搐 #6109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CiiLu wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −0
Open

fix: #5343 陶瓦联机界面账号快速切换列表右侧滚动条错位以及列表莫名抽搐 #6109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fe0377
qwq
CiiLu May 16, 2026
9337a0d
qwq
CiiLu May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions HMCL/src/main/java/org/jackhuang/hmcl/ui/account/AccountListPopupMenu.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package org.jackhuang.hmcl.ui.account;

import com.jfoenix.controls.JFXPopup;
import javafx.application.Platform;
import javafx.beans.InvalidationListener;
import javafx.beans.WeakInvalidationListener;
import javafx.beans.binding.Bindings;
Expand Down Expand Up @@ -64,6 +65,8 @@ public AccountListPopupMenu() {
});
box.add(item);
}

Platform.runLater(() -> box.setVvalue(Double.MIN_VALUE));
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using Double.MIN_VALUE to reset the scroll position is semantically incorrect. In Java, Double.MIN_VALUE is the smallest positive non-zero value ($4.9 \times 10^{-324}$), not the minimum possible value (which would be -Double.MAX_VALUE). For a ScrollPane's vvalue, the valid range is typically 0.0 to 1.0. While Double.MIN_VALUE is effectively 0.0 due to precision, it is clearer and more idiomatic to use 0.0 or box.getVmin().

Suggested change
Platform.runLater(() -> box.setVvalue(Double.MIN_VALUE));
Platform.runLater(() -> box.setVvalue(0.0));

};
listener.invalidated(null);
Accounts.getAccounts().addListener(new WeakInvalidationListener(listener));
Expand Down