Skip to content

hlkxmerge: add HLKX package merge engine#1024

Open
elizashurov wants to merge 1 commit into
HCK-CI:masterfrom
elizashurov:RHELMISC-35996
Open

hlkxmerge: add HLKX package merge engine#1024
elizashurov wants to merge 1 commit into
HCK-CI:masterfrom
elizashurov:RHELMISC-35996

Conversation

@elizashurov

Copy link
Copy Markdown
Contributor
  • Add HLKXMerge engine that boots a Studio VM, uploads local HLKX packages, merges them via the HLK API, and downloads the result
  • Register hlkxmerge in the engine selector, autoload, and config.json
  • Add merge CLI subcommand with --platform, --packages, and --output options

@elizashurov elizashurov requested a review from kostyanf14 July 9, 2026 08:05
@elizashurov

Copy link
Copy Markdown
Contributor Author

@kostyanf14 This PR depends on the rtoolsHCK PR
once it's merged, I'll push a commit bumping rtoolsHCK version

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new HLKXMerge engine to merge multiple HLKX packages into one using the HLK API on a Studio VM, registering it across the configuration, autoloading, and CLI options. It also adds safe navigation to prevent a potential nil-pointer exception when iterating over clients. The review feedback highlights two important improvements: first, validating the merge result to ensure failures are not silently ignored and explicitly raising an error; second, validating the platform_name input to prevent a potential path traversal vulnerability when constructing the platform JSON file path.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lib/engines/hlkxmerge/hlkxmerge.rb
Comment thread lib/engines/hlkxmerge/hlkxmerge.rb
- Add HLKXMerge engine that boots a Studio VM, uploads local HLKX
  packages, merges them via the HLK API, and downloads the result
- Register hlkxmerge in the engine selector, autoload, and config.json
- Add `merge` CLI subcommand with --platform, --packages, and --output
  options

Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant