-
Notifications
You must be signed in to change notification settings - Fork 305
Modernise package for PHP 8.2+ #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 21 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
3bcf60d
tmpdir and null safe strtolower
lachlan-00 30e8155
add phpstan
lachlan-00 dd00d87
start php8.0+
lachlan-00 21cc047
keep typing
lachlan-00 5656c79
phpstan clean for php8.0
lachlan-00 ada1ff7
work on tests
lachlan-00 4f7d1da
fix for tests
lachlan-00 810d015
Update CaptchaBuilder.php
lachlan-00 8678ef2
Merge pull request #1 from lachlan-00/php8
lachlan-00 8831ce2
send ints for typing error
lachlan-00 b22e385
convert has null output
lachlan-00 bac1d9e
Merge pull request #2 from lachlan-00/php8
lachlan-00 305c183
set default values for phrase properties
lachlan-00 03f5c5c
remove < 7.4 check
lachlan-00 a5abf50
inspection changes
lachlan-00 f059d1a
Merge branch 'php8'
lachlan-00 22c4f6a
copilot request comments
lachlan-00 6d639dd
Merge branch 'php8'
lachlan-00 da8a64f
strict comparison
lachlan-00 09e29bb
add version constant
lachlan-00 3dc8681
fileinfo included in newer php's
lachlan-00 4cf363b
require-dev squizlabs/php_codesniffer
lachlan-00 d1e66e4
8.5 is stable
lachlan-00 3b2267e
tempdir property and __construct order
lachlan-00 c65bfc7
semi revert gcfreq
lachlan-00 821ab9d
sort .gitignore
lachlan-00 323300d
restore ext-fileinfo
lachlan-00 5599757
Update composer.json
lachlan-00 f38e1de
Update phpunit.xml.dist
lachlan-00 003d11a
default values are already set for phrase builder
lachlan-00 b59bd2a
clear phpcs warnings for line length
lachlan-00 3348051
wip
bytestream c8e5c00
remove unused ImageFIleHandler
bytestream 8962a6a
phpcbf
bytestream 9d4bd7e
Clear php 8.5 errors
lachlan-00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| parameters: | ||
| level: 8 | ||
| reportUnmatchedIgnoredErrors: false | ||
| paths: | ||
| - src/ | ||
| - tests/ | ||
| treatPhpDocTypesAsCertain: false | ||
| includes: | ||
| - phpstan-baseline.neon |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,13 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
|
|
||
| <phpunit colors="true" bootstrap="vendor/autoload.php"> | ||
| <testsuites> | ||
| <testsuite name="KnpMenu Test Suite"> | ||
| <directory suffix="Test.php">./tests/</directory> | ||
| </testsuite> | ||
| </testsuites> | ||
|
|
||
| <filter> | ||
| <whitelist> | ||
| <directory>./src</directory> | ||
| </whitelist> | ||
| </filter> | ||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" colors="true" bootstrap="vendor/autoload.php" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"> | ||
| <coverage> | ||
| <include> | ||
| <directory>./src</directory> | ||
| </include> | ||
| </coverage> | ||
| <testsuites> | ||
| <testsuite name="KnpMenu Test Suite"> | ||
|
bytestream marked this conversation as resolved.
Outdated
|
||
| <directory suffix="Test.php">./tests/</directory> | ||
| </testsuite> | ||
| </testsuites> | ||
| </phpunit> | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.