[1.20.6+] Changed password input to use an anvil inventory as gui. - #9
[1.20.6+] Changed password input to use an anvil inventory as gui.#9FireInstall wants to merge 5 commits into
Conversation
|
One thing and one thing only would be better than this and that would be hooking in even earlier / deeper and work only on packet level. |
|
Also, whenever this is about to get merged: |
74cbd52 to
9dd04a2
Compare
|
Update: Seems like nms code doesn't break any and every version anymore. Only ever if Mojang (or further downstream) changes anyghing. Hurray! May get interesting, if this ever becomes a true paper plugin and doesn't get threaded like a spigot one anymore (remap and reflection to new paper methodes) |
140b56f to
8281c6d
Compare
|
Could run in earlier versions, but since this works with nms code this should get used with 1.20.5+. |
That way a password can't get leaked by typing the command wrongly anymore. But, to make this possible I had to dig into nms code.
Also missed clearing closed guis
|
force push onto main |
|
May be obslete with https://minecraft.wiki/w/Dialog and the corresponding paper API. |
|
Maybe. But depending on how paper implements the new dialog api, I can foresee myself still needing nms-usage. |
That way a password can't get leaked by typing the command wrongly anymore. But, to make this possible I had to dig into nms code.
For now I don't know how easy this breaks in case of version updates.
So this should stay open until next major 1.21 subversion gets released and this can get propper tested!