Skip to content

[1.20.6+] Changed password input to use an anvil inventory as gui. - #9

Open
FireInstall wants to merge 5 commits into
mainfrom
GUI
Open

[1.20.6+] Changed password input to use an anvil inventory as gui.#9
FireInstall wants to merge 5 commits into
mainfrom
GUI

Conversation

@FireInstall

@FireInstall FireInstall commented Jun 3, 2024

Copy link
Copy Markdown
Collaborator

That way a password can't get leaked by typing the command wrongly anymore. But, to make this possible I had to dig into nms code.
For now I don't know how easy this breaks in case of version updates.
So this should stay open until next major 1.21 subversion gets released and this can get propper tested!

@FireInstall

Copy link
Copy Markdown
Collaborator Author

One thing and one thing only would be better than this and that would be hooking in even earlier / deeper and work only on packet level.
But that's not fun at all.

@FireInstall

Copy link
Copy Markdown
Collaborator Author

Also, whenever this is about to get merged:
Please bump the version number!

@FireInstall
FireInstall force-pushed the GUI branch 2 times, most recently from 74cbd52 to 9dd04a2 Compare June 19, 2024 04:01
@FireInstall

FireInstall commented Jun 30, 2024

Copy link
Copy Markdown
Collaborator Author

Update: Seems like nms code doesn't break any and every version anymore. Only ever if Mojang (or further downstream) changes anyghing. Hurray!

May get interesting, if this ever becomes a true paper plugin and doesn't get threaded like a spigot one anymore (remap and reflection to new paper methodes)

@FireInstall
FireInstall force-pushed the GUI branch 2 times, most recently from 140b56f to 8281c6d Compare July 28, 2024 13:45
@FireInstall FireInstall changed the title Changed password input to use an anvil inventory as gui. [1.21] Changed password input to use an anvil inventory as gui. Sep 7, 2024
@FireInstall

Copy link
Copy Markdown
Collaborator Author

Could run in earlier versions, but since this works with nms code this should get used with 1.20.5+.
Since our server will skipp this version and instead catch up to 1.21.1? this should get merged with the 1.21 stuff.

That way a password can't get leaked by typing the command wrongly anymore.
But, to make this possible I had to dig into nms code.
@FireInstall

Copy link
Copy Markdown
Collaborator Author

force push onto main

@FireInstall FireInstall changed the title [1.21] Changed password input to use an anvil inventory as gui. [1.20.6+] Changed password input to use an anvil inventory as gui. Sep 7, 2024
@Schpammer

Copy link
Copy Markdown
Collaborator

May be obslete with https://minecraft.wiki/w/Dialog and the corresponding paper API.

@FireInstall

Copy link
Copy Markdown
Collaborator Author

Maybe. But depending on how paper implements the new dialog api, I can foresee myself still needing nms-usage.
I will have a look into that once paper has merged PaperMC/Paper#12671
Or better even something stable instead of temporary methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants