Fix collapsed import self-loops#2038
Draft
Endogen wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
imports,imports_from, andre_exportsedges when endpoint resolution collapses them into self-loopscallsself-loops remain intactFixes #2037.
Root cause
AST extraction can emit unresolved bare import targets such as
builtins,contracting, orposeidon. The legacy-ID alias index inbuild_from_json()may then resolve that bare target to the importing file's own canonical node. Materializing the resolved edge creates a file-level self-loop that carries no connectivity and is flagged bygraphify diagnose multigraph.The filter is intentionally relation-specific. It removes only collapsed import/re-export edges and preserves other self-edges, including recursive calls.
Impact
Rebuilt graphs no longer contain false import self-loops caused by basename/legacy-alias resolution. This eliminates diagnostic noise without changing application code or hiding real recursive program structure.
Validation
uv run pytest tests/ -q— 3,478 passed, 3 skippeduv run ruff check .— passed